digraph_utils: use strong components for roots, not just components #10510
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 2 files 97 suites 1h 7m 30s ⏱️ Results for commit 10fb9c5. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Contributor
Author
|
Something seems broken in the license header checks, perhaps due to the new year? |
richcarl
force-pushed
the
digraph-fixes
branch
2 times, most recently
from
47b01c7 to
72f0716
Compare
rickard-green
added
team:VM
Contributor
Yes, and yes. |
Selecting a random node of a component as root may start in a dead end, so that the rest of the component is not traversed. The root selection needs to use cyclic strong components.
richcarl
force-pushed
the
digraph-fixes
branch
from
72f0716 to
10fb9c5
Compare
jhogberg
added
testing
jhogberg
approved these changes
Jan 20, 2026
Contributor
|
Merged, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a random node of a component as root may start in a dead end, so that the rest of the component is not traversed. The root selection needs to use cyclic strong components.